Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improvement function on common #850

Merged
merged 3 commits into from
Jul 25, 2024
Merged

chore: improvement function on common #850

merged 3 commits into from
Jul 25, 2024

Conversation

slowy07
Copy link
Member

@slowy07 slowy07 commented Jul 25, 2024

improvement function on common by

  • using fstring for clearer and more efficient string formatting
  • add specific RequestException for handling all request related about exception
  • using raise_for_status() for cleaner and following PEP convention
  • using pathlib for better path handling
  • check for pip using more reliable method
  • using subprocess.run instead os.system for better security issue and error handling

@giswqs
Copy link
Member

giswqs commented Jul 25, 2024

Fixed the docs-build error

@slowy07
Copy link
Member Author

slowy07 commented Jul 25, 2024

check pass test

@slowy07 slowy07 merged commit 2a6c981 into opengeos:master Jul 25, 2024
13 checks passed
@slowy07 slowy07 deleted the improvement-fn branch July 25, 2024 03:57
kuzja111 pushed a commit to kuzja111/leafmap that referenced this pull request Jul 25, 2024
chore: improvement function on common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants