Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuantityType.toUnitRelative #3177

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 26, 2022

this is a useful helper that can eliminate some complicated code elsewhere. starting in SystemOffsetProfile. then I also want to use it in the homekit addon.

extracted from #3132, since the StateDescription portion of that PR is still being discussed what direction to go

this is a useful helper that can eliminate some complicated code elsewhere.
starting in SystemOffsetProfile. then I also want to use it in the homekit
addon.

Signed-off-by: Cody Cutrer <[email protected]>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K added enhancement An enhancement or new feature of the Core UoM Units of Measurement labels Nov 27, 2022
@J-N-K J-N-K added this to the 3.4 milestone Nov 27, 2022
@J-N-K J-N-K merged commit af37384 into openhab:main Nov 27, 2022
@ccutrer ccutrer deleted the to-unit-relative branch November 29, 2022 16:15
@wborn wborn changed the title add QuantityType.toUnitRelative Add QuantityType.toUnitRelative Nov 30, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/working-with-number-temperature-items-in-rules/116197/25

splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
this is a useful helper that can eliminate some complicated code elsewhere.
starting in SystemOffsetProfile. then I also want to use it in the homekit
addon.

Signed-off-by: Cody Cutrer <[email protected]>
GitOrigin-RevId: af37384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core UoM Units of Measurement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants