Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ProfileTypeBuilder to pass its three filters list to both implementations of ProfileType #4325

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Allow ProfileTypeBuilder to pass its three filters list to both implementations of ProfileType #4325

wants to merge 9 commits into from

Commits on Jul 22, 2024

  1. Move getSupportedChannelTypeUIDs and getSupportedItemTypesOfChannel t… 

    …o the ProfileType interface so that StateProfileType and TriggerProfileType can both take the three filter lists given by ProfileTypeBuilder

Fixes openhab#4293

Signed-off-by: Olivier Sannier <[email protected]> (github: obones)
Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a3fea88 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Use getSupportedChannelTypeUIDs and getSupportedItemTypesOfChannel on… 

    … all ProfileTypes

Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    347fbe7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Introduce getSupportedChannelKind on ProfileType so that a given prof… 

    …ile type can tell onto which channel kind it applies, if any

Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e092440 View commit details
    Browse the repository at this point in the history

  2. Must check for the channel kind supported by the profile type 

    Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7d37835 View commit details
    Browse the repository at this point in the history

  3. Must not exit too early, both lists must be tested 

    Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e3052cc View commit details
    Browse the repository at this point in the history

  4. Use code similar to the one in ProfileTypeResource for better consist… 

    …ency

Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    116046b View commit details
    Browse the repository at this point in the history

  5. Improve the javadoc for ProfileType 

    Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    86e6852 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Remove @nullable on local variables 

    Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    ef03c14 View commit details
    Browse the repository at this point in the history

  2. Rewrite the link() tests for better styling and make them similar to … 

    …the two other locations where ProfileType are tested for applicability

Signed-off-by: OBones <[email protected]>
    @obones
    obones committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d0130fd View commit details
    Browse the repository at this point in the history