-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP addon finder: add support for sending local mac address #4477
Conversation
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Ping => @holgerfriedrich / @jlaur / @ccutrer |
...scovery.addon.ip/src/main/java/org/openhab/core/config/discovery/addon/ip/IpAddonFinder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <[email protected]>
I've been playing with discovery of my wiz bulbs this morning, and I've determined that indeed the Mac and IP address don't matter:
So if you don't want to deal with the complications of this, you don't have to. I still have to figure out actually doing this in broadcast mode, not unicast, though. |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
Umm :( |
...scovery.addon.ip/src/main/java/org/openhab/core/config/discovery/addon/ip/IpAddonFinder.java
Outdated
Show resolved
Hide resolved
Well, then I might as well use it :). I updated openhab/openhab-addons#17856 |
Signed-off-by: Andrew Fiddian-Green <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andrewfg. Thanks for the useful addition.
See my comment below regarding the binary request array.
May I ask you to create a PR in docs repo as well?
https://next.openhab.org/docs/developer/addons/addon.html#discovery-methods
Adds support for a
srcMac
substitution token which allows the scan packets to include the source mac address.The mac address is formatted by the given
fmtMac
format specifier.See openhab/openhab-addons#17847
Signed-off-by: Andrew Fiddian-Green [email protected]