Warning hunt in org.openhab.core.addon.xxx #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaël L'hopital <[email protected]>
...g/openhab/core/addon/marketplace/internal/community/CommunityTransformationAddonHandler.java
Show resolved
Hide resolved
|
LGTM, thanks. Reducing warnings is always appreciated. 👍 Though, I think due to the code freeze, this PR might be delayed until 4.3 is released. |
jlaur
reviewed
Dec 13, 2024
Comment on lines
143
to
144
| Long localQualifier = qualifier; | ||
| if (localQualifier == null) { // we are the release |
There was a problem hiding this comment.
Nitty gritty: The naming seems inconsistent compared to otherQualifier below. For otherQualifier the semantic is different because other refers to quality in other rather than in this, whereas local refers to the variable being in local scope (I presume). localQualifier and localOtherQualifier seems maybe a bit too much, so perhaps simply thisQualifier and otherQualifier?
Suggested change
| Long localQualifier = qualifier; | |
| if (localQualifier == null) { // we are the release | |
| Long thisQualifier = qualifier; | |
| if (thisQualifier == null) { // we are the release |
jlaur
reviewed
Dec 13, 2024
| return -1; | ||
| } | ||
|
|
||
| // both versions are milestones, we can compare them | ||
| return Long.compare(qualifier, other.qualifier); | ||
| return Long.compare(localQualifier, otherQualifier); |
There was a problem hiding this comment.
Suggested change
| return Long.compare(localQualifier, otherQualifier); | |
| return Long.compare(thisQualifier, otherQualifier); |
Signed-off-by: Gaël L'hopital <[email protected]>
jlaur
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minus 19 warnings