-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hdf5: Update to 1.14.5 #2041
Merged
Merged
hdf5: Update to 1.14.5 #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
The error in the tests is not very clear to me... |
I was running it locally in a container and I saw:
The test compares the output of the tools with some predefined output. Not sure where the predefined output comes from. Maybe that needs to be updated. |
Here is the diff: :49:38.9351165Z ================================================
2024-10-17T13:49:38.9351892Z Log file: ./tests/libs/hdf5/test-env-variables-new/C/H5T/h5ex_t_vlen.ddl.diff.log
2024-10-17T13:49:38.9352645Z --- tmp.test 2024-10-17 13:49:22.049008370 +0000
2024-10-17T13:49:38.9353225Z +++ ./testfiles/114/h5ex_t_vlen.ddl 2024-10-17 13:47:41.836252996 +0000
2024-10-17T13:49:38.9353818Z @@ -1,7 +1,7 @@
2024-10-17T13:49:38.9354154Z HDF5 "h5ex_t_vlen.h5" {
2024-10-17T13:49:38.9354464Z GROUP "/" {
2024-10-17T13:49:38.9354835Z DATASET "DS1" {
2024-10-17T13:49:38.9355252Z - DATATYPE H5T_VLEN { H5T_STD_I32LE }
2024-10-17T13:49:38.9355662Z + DATATYPE H5T_VLEN { H5T_STD_I32LE}
2024-10-17T13:49:38.9356182Z DATASPACE SIMPLE { ( 2 ) / ( 2 ) }
2024-10-17T13:49:38.9356584Z DATA {
2024-10-17T13:49:38.9356932Z (0): (3, 2, 1), (1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144)
2024-10-17T13:49:38.9357491Z ================================================
2024-10-17T13:49:38.9358232Z Log file: ./tests/libs/hdf5/test-env-variables-new/C/H5T/h5ex_t_vlenatt.ddl.diff.log
2024-10-17T13:49:38.9358882Z --- tmp.test 2024-10-17 13:49:22.065008477 +0000
2024-10-17T13:49:38.9359570Z +++ ./testfiles/114/h5ex_t_vlenatt.ddl 2024-10-17 13:47:41.836252996 +0000
2024-10-17T13:49:38.9360248Z @@ -6,7 +6,7 @@
2024-10-17T13:49:38.9360531Z DATA {
2024-10-17T13:49:38.9360920Z }
2024-10-17T13:49:38.9361220Z ATTRIBUTE "A1" {
2024-10-17T13:49:38.9361635Z - DATATYPE H5T_VLEN { H5T_STD_I32LE }
2024-10-17T13:49:38.9362153Z + DATATYPE H5T_VLEN { H5T_STD_I32LE}
2024-10-17T13:49:38.9362603Z DATASPACE SIMPLE { ( 2 ) / ( 2 ) }
2024-10-17T13:49:38.9362996Z DATA {
2024-10-17T13:49:38.9363438Z (0): (3, 2, 1), (1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144) |
martin-g
force-pushed
the
hdf5-1.14.5
branch
7 times, most recently
from
October 21, 2024 07:06
01448e6
to
63ae793
Compare
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@adrianreber Please review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.