Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Details #2525

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix Details #2525

merged 1 commit into from
Aug 21, 2024

Conversation

dgqypl
Copy link
Contributor

@dgqypl dgqypl commented Aug 16, 2024 •
edited by mo3et
Loading

  1. Unify the receiver of structure methods and use pointer
  2. Use errors.Is to make error judgments
  3. Fix word spelling errors

@dgqypl
fix 细节
951f1c7 
1、统一结构体方法 receiver，都用 pointer
2、使用 errors.Is 来做错误判断
3、修复单词拼写的错误
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

🤖 All Contributors have signed the CLA.
The signed information is recorded 🤖here
Posted by the CLA Assistant Lite bot.

@dgqypl
Copy link
Contributor Author

dgqypl commented Aug 19, 2024 •
edited by mo3et
Loading

The signature to be committed in order to sign the CLA

@mo3et
Copy link
Member

mo3et commented Aug 19, 2024

recheck

OpenIM-Robot added a commit to OpenIM-Robot/cla that referenced this pull request Aug 19, 2024
@OpenIM-Robot
@mo3et has signed the CLA in openimsdk/open-im-server#2525
bc33399
@mo3et mo3et changed the title fix 细节 fix Details Aug 19, 2024
@FGadvancer FGadvancer added this pull request to the merge queue Aug 21, 2024
Merged via the queue into openimsdk:main with commit 1022b29 Aug 21, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mo3et mo3et mo3et approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgqypl @mo3et @FGadvancer