Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338136: Hotspot should support multiple large page sizes on Windows #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhanalla
Copy link
Contributor

@dhanalla dhanalla commented Nov 8, 2024

Backport of openjdk/jdk#20758


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8343896 to be approved
  • JDK-8338136 needs maintainer approval

Issues

  • JDK-8338136: Hotspot should support multiple large page sizes on Windows (Enhancement - P3)
  • JDK-8343896: Hotspot should support multiple large page sizes on Windows (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/219/head:pull/219
$ git checkout pull/219

Update a local copy of the PR:
$ git checkout pull/219
$ git pull https://git.openjdk.org/jdk23u.git pull/219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 219

View PR using the GUI difftool:
$ git pr show -t 219

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/219.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2024

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4ded28380b6756e0679d80706f76bd6e78c370b9 8338136: Hotspot should support multiple large page sizes on Windows Nov 8, 2024
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 8, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2024

@dhanalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant