-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composite provider to support multiple network providers #224
Add composite provider to support multiple network providers #224
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 43.63% 43.27% -0.37%
==========================================
Files 52 53 +1
Lines 5681 5849 +168
==========================================
+ Hits 2479 2531 +52
- Misses 2778 2877 +99
- Partials 424 441 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
645cb4d
to
50a3871
Compare
@lujiajing1126 There is no problem with the code logic and implementation. We didn't implement it before mainly because we didn't think through the scenarios, so would it be convenient for you to participate in a community meeting? Time: 7.11. Alternatively, you can join the dingding group and we'll talk further! |
Yes, sure. I've already in the Dingtalk group and will attend the community meeting on 11, Jul. |
f10a004
to
ed6819f
Compare
return nil | ||
} | ||
|
||
func (c CompositeController) EnsureRoutes(ctx context.Context, strategy *v1beta1.TrafficRoutingStrategy) (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the logic of CustomNetworkProvider
here.
Gentle Ping @myname4423 @zmberg for review
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
94c048e
to
844d656
Compare
Signed-off-by: Megrez Lu <[email protected]>
Test cases have been moved to v1beta1 file and a workflow has been added. @myname4423 |
/lgtm |
Ⅰ. Describe what this PR does
Currently, only a single trafficRouting network provider is supported even multiple ones are defined.
To accomplish this, a composite provider is needed. A composite provider is just an array of
NetworkProvider
.Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews