support bluegreen release: support workload of deployment and cloneSet #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furykerry
reviewed
Nov 13, 2024
pkg/controller/batchrelease/control/bluegreenstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
| util.InitOriginalSetting(&setting, rc.object) | ||
| klog.InfoS("Initialize deployment", "deployment", klog.KObj(rc.object), "setting", util.DumpJSON(&setting)) | ||
|
|
||
| d := rc.object.DeepCopy() |
There was a problem hiding this comment.
the obj params of patch field is used to pass the object meta and to store the patched obj, since d is not used anywhere, it is not necessary to deepcopy the object. simply initiate a empty deployment with the namespace/name of obj using GetEmptyObjectWithKey
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
furykerry
reviewed
Nov 14, 2024
myname4423
force-pushed
the
bluegreen
branch
from
aca5c93 to
ab52d6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 43.63% 45.00% +1.36%
==========================================
Files 52 60 +8
Lines 5681 6931 +1250
==========================================
+ Hits 2479 3119 +640
- Misses 2778 3279 +501
- Partials 424 533 +109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
furykerry
reviewed
Nov 25, 2024
furykerry
reviewed
Nov 25, 2024
pkg/controller/batchrelease/control/bluegreenstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
myname4423
force-pushed
the
bluegreen
branch
2 times, most recently
from
b8bd5b5 to
6fed8e1
Compare
furykerry
reviewed
Dec 9, 2024
pkg/controller/batchrelease/control/bluegreenstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/bluegreenstyle/deployment/control.go
Show resolved
Hide resolved
furykerry
reviewed
Dec 9, 2024
Signed-off-by: yunbo <[email protected]>
Signed-off-by: yunbo <[email protected]>
Signed-off-by: yunbo <[email protected]>
myname4423
force-pushed
the
bluegreen
branch
from
9719408 to
1a4f00e
Compare
Signed-off-by: yunbo <[email protected]>
myname4423
force-pushed
the
bluegreen
branch
from
1a4f00e to
6885920
Compare
|
/lgtm |
zmberg
reviewed
Dec 23, 2024
| @@ -148,6 +148,7 @@ type BatchReleaseReconciler struct { | |||
| // +kubebuilder:rbac:groups=apps.kruise.io,resources=statefulsets/status,verbs=get;update;patch | |||
| // +kubebuilder:rbac:groups=apps.kruise.io,resources=daemonsets,verbs=get;list;watch;update;patch | |||
| // +kubebuilder:rbac:groups=apps.kruise.io,resources=daemonsets/status,verbs=get;update;patch | |||
| // +kubebuilder:rbac:groups=autoscaling,resources=horizontalpodautoscalers,verbs=get;list;watch;create;update;patch;delete | |||
There was a problem hiding this comment.
verbs=get;list;watch;update;patch
| } | ||
|
|
||
| func (rc *realController) Initialize(release *v1beta1.BatchRelease) error { | ||
| klog.Info("Initialize cloneset controller") |
| desired, _ := intstr.GetScaledValueFromIntOrPercent(&ctx.DesiredSurge, int(ctx.Replicas), true) | ||
| current, _ := intstr.GetScaledValueFromIntOrPercent(&ctx.CurrentSurge, int(ctx.Replicas), true) | ||
| if current >= desired { | ||
| klog.Infof("No need to upgrade batch for cloneset %v: because current %d >= desired %d", klog.KObj(rc.object), current, desired) |
| return errors.NewRetryError(fmt.Errorf("cloneset %v finalize not done, readyReplicas %d != updatedReadyReplicas %d, current policy %s", | ||
| klog.KObj(rc.object), rc.object.Status.ReadyReplicas, rc.object.Status.UpdatedReadyReplicas, release.Spec.ReleasePlan.FinalizingPolicy)) | ||
| } | ||
| klog.InfoS("Finalize: cloneset bluegreen release: all pods updated and ready") |
Signed-off-by: yunbo <[email protected]>
Signed-off-by: yunbo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
controller/batchrelease, to support bluegreen style releaseⅡ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews