Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code space env #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jun 16, 2022

This PR adds a dockerfile and user environment for anyone wanting to spin up these examples in github codespaces.

I've demonstrated this to @pshriwise as it provides an easy back up option for the live demo at the IAEA conference.

For this to be most effective code spaces would ideally be enabled on this github org but perhaps that is a step to far

@shimwell shimwell marked this pull request as draft June 16, 2022 18:03
@shimwell shimwell marked this pull request as ready for review June 23, 2022 08:53
"python.linting.enabled": true,
"python.linting.pylintEnabled": true,
"python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8",
"python.formatting.blackPath": "/usr/local/py-utils/bin/black",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"python.formatting.blackPath": "/usr/local/py-utils/bin/black",

We can remove the formatting tool from this PR as mentioned earlier @paulromano

@RemDelaporteMathurin
Copy link

Wow, thanks @shimwell for showing me this.

I ran this repo in a codespace, it took a little while to build.
But then everything was like developping locally.
You can even open the codespace locally (in VSC) which is in fact 100% local development!

I highly recommend making the openmc repo codespaces friendly and even consider it for my current projects!

It appears that the potential long building stage can be solved by pre-building the image (Am I right @shimwell ?)

@shimwell
Copy link
Member Author

shimwell commented Jul 3, 2022

Yep prebuilds would bring down the time to launch and can be setup in the repo settings. Most of the current install time is due to nuclear data downloading, so it could also be shorter by dynamically getting the data using on the fly data downloading if we want https://pypi.org/project/openmc-data-downloader/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants