Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/O3-3846: All Calendar Date Pickers should use the same OpenmrsDatePicker component across entire EMR #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Nov 13, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I fixed the OrdersDateRangePicker component to use the OpenmrsDatePicker component from the @openmrs/esm-framework allowing users to select start and finish dates within the current day while managing the state of the date range.

Screenshots

screencast.2024-11-14.1.AM-17-04.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3846

Other

@jwnasambu
Copy link
Contributor Author

@ibacher, @denniskigen, Kindly feel free to review my PR at your convenience! please.

@ibacher
Copy link
Member

ibacher commented Nov 14, 2024

For right now, I think we should skip these range pickers until we add that capability to the OpenmrsDatePicker (or add an OpenmrsDateRangePicker component).

@jwnasambu
Copy link
Contributor Author

@ibacher I opted to add an OpenmrsDateRangePicker component).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants