Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-1208 Timeline LabSet Name Should Update with Vertical Scroll #2016

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

(fix) O3-1208 Timeline LabSet Name Should Update with Vertical Scroll #2016

wants to merge 4 commits into from

Conversation

suubi-joshua
Copy link
Contributor

@suubi-joshua suubi-joshua commented Sep 17, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Added currentTitle variable to track current panel title in useScroll hook

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-1208

Other

CynthiaKamau
CynthiaKamau reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suubi-joshua , are you still working on this ?

@suubi-joshua
Copy link
Contributor Author

Not at the moment @CynthiaKamau I saw they are new designs for the timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CynthiaKamau CynthiaKamau CynthiaKamau left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suubi-joshua @CynthiaKamau