Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-4022 Ward App add loading skeleton to bed divider #1370

Merged
merged 4 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/esm-ward-app/src/beds/bed-share-divider.component.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { Skeleton, Tag } from '@carbon/react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be SkeletonText instead. Sorry.

import React from 'react';
import { useTranslation } from 'react-i18next';
import styles from './bed-share-divider.scss';

interface BedShareDividerProps {
isLoading?: boolean;
}

const BedShareDivider: React.FC<BedShareDividerProps> = ({ isLoading }) => {
const { t } = useTranslation();
return (
<div className={styles.bedDivider}>
<div className={styles.bedDividerLine}></div>
{isLoading ? <SkeletonText /> : <Tag>{t('bedShare', 'Bed share')}</Tag>}
<div className={styles.bedDividerLine}></div>
</div>
);
};

export default BedShareDivider;
18 changes: 18 additions & 0 deletions packages/esm-ward-app/src/beds/bed-share-divider.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
@use '@carbon/layout';
@use '@openmrs/esm-styleguide/src/vars' as *;
@use '@carbon/type';

.bedDivider {
background-color: $ui-02;
color: $text-02;
padding: layout.$spacing-01;
display: flex;
align-items: center;
justify-content: space-between;
}

.bedDividerLine {
height: 1px;
background-color: $ui-05;
width: 30%;
}
24 changes: 7 additions & 17 deletions packages/esm-ward-app/src/beds/ward-bed.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,30 @@ import React, { type ReactNode } from 'react';
import { type Bed } from '../types';
import EmptyBed from './empty-bed.component';
import styles from './ward-bed.scss';
import { useTranslation } from 'react-i18next';
import { Tag } from '@carbon/react';
import BedShareDivider from './bed-share-divider.component';

export interface WardBedProps {
patientCards: Array<ReactNode>;
bed: Bed;
isLoadingDivider?: boolean;
}

const WardBed: React.FC<WardBedProps> = ({ bed, patientCards }) => {
return patientCards?.length > 0 ? <OccupiedBed bed={bed} patientCards={patientCards} /> : <EmptyBed bed={bed} />;
const WardBed: React.FC<WardBedProps> = (props) => {
const { bed, patientCards } = props;
return patientCards?.length > 0 ? <OccupiedBed {...props} /> : <EmptyBed bed={bed} />;
};

const OccupiedBed: React.FC<WardBedProps> = ({ patientCards }) => {
const OccupiedBed: React.FC<WardBedProps> = ({ patientCards, isLoadingDivider }) => {
// interlace patient card with bed dividers between each of them
const patientCardsWithDividers = patientCards.flatMap((patientCard, index) => {
if (index == 0) {
return [patientCard];
} else {
return [<BedShareDivider key={'divider-' + index} />, patientCard];
return [<BedShareDivider key={'divider-' + index} isLoading={isLoadingDivider} />, patientCard];
}
});

return <div className={styles.occupiedBed}>{patientCardsWithDividers}</div>;
};

const BedShareDivider = () => {
const { t } = useTranslation();
return (
<div className={styles.bedDivider}>
<div className={styles.bedDividerLine}></div>
<Tag>{t('bedShare', 'Bed share')}</Tag>
<div className={styles.bedDividerLine}></div>
</div>
);
};

export default WardBed;
16 changes: 1 addition & 15 deletions packages/esm-ward-app/src/beds/ward-bed.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,6 @@
height: fit-content;
}

.bedDivider {
background-color: vars.$ui-02;
color: vars.$text-02;
padding: layout.$spacing-01;
display: flex;
align-items: center;
justify-content: space-between;
}

.bedDividerLine {
height: 1px;
background-color: vars.$ui-05;
width: 30%;
}
.emptyBed {
display: flex;
gap: layout.$spacing-04;
Expand All @@ -42,4 +28,4 @@
.emptyBedText {
@include type.type-style('heading-compact-01');
color: vars.$text-02;
}
}
1 change: 1 addition & 0 deletions packages/esm-ward-app/src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ export interface PatientAndAdmission {
export interface MotherChildRelationships {
motherByChildUuid: Map<string, PatientAndAdmission>;
childrenByMotherUuid: Map<string, PatientAndAdmission[]>;
isLoading: boolean;
}

export interface MaternalWardViewContext {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { bedLayoutToBed } from '../ward-view.resource';
import MaternalWardPatientCard from './maternal-ward-patient-card.component';

const MaternalWardBeds: React.FC<MotherChildRelationships> = (motherChildRelationships) => {
const { motherByChildUuid } = motherChildRelationships ?? {};
const { motherByChildUuid, isLoading: isLoadingMotherChildRelationships } = motherChildRelationships ?? {};
const { wardPatientGroupDetails } = useAppContext<WardViewContext>('ward-view-context') ?? {};
const { bedLayouts, wardAdmittedPatientsWithBed } = wardPatientGroupDetails ?? {};

Expand Down Expand Up @@ -56,7 +56,14 @@ const MaternalWardBeds: React.FC<MotherChildRelationships> = (motherChildRelatio
/>
));

return <WardBed key={bed.uuid} bed={bed} patientCards={patientCards} />;
return (
<WardBed
key={bed.uuid}
bed={bed}
patientCards={patientCards}
isLoadingDivider={isLoadingMotherChildRelationships}
/>
);
});

return <>{wardBeds}</>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@ import { showNotification } from '@openmrs/esm-framework';
import { useMemo } from 'react';
import { useTranslation } from 'react-i18next';
import { useMotherAndChildren, type MothersAndChildrenSearchCriteria } from '../../hooks/useMotherAndChildren';
import { type PatientAndAdmission } from '../../types';
import { type MotherChildRelationships, type PatientAndAdmission } from '../../types';

const motherAndChildrenRep =
'custom:(childAdmission,mother:(person,identifiers:full,uuid),child:(person,identifiers:full,uuid),motherAdmission)';

export function useMotherChildrenRelationshipsByPatient(allWardPatientUuids: string[], fetch: boolean) {
export function useMotherChildrenRelationshipsByPatient(
allWardPatientUuids: string[],
fetch: boolean,
): MotherChildRelationships {
const { t } = useTranslation();

const getChildrenRequestParams: MothersAndChildrenSearchCriteria = {
Expand Down Expand Up @@ -53,12 +56,9 @@ export function useMotherChildrenRelationshipsByPatient(allWardPatientUuids: str
}

const relationships = useMemo(() => {
if (isLoadingChildrenData || isLoadingMotherData) {
return null;
}

const motherByChildUuid = new Map<string, PatientAndAdmission>();
const childrenByMotherUuid = new Map<string, PatientAndAdmission[]>();
const isLoading = isLoadingChildrenData || isLoadingMotherData;

for (const { child, childAdmission, mother, motherAdmission } of motherData ?? []) {
motherByChildUuid.set(child.uuid, { patient: mother, currentAdmission: motherAdmission });
Expand All @@ -82,7 +82,7 @@ export function useMotherChildrenRelationshipsByPatient(allWardPatientUuids: str
}
}

return { motherByChildUuid, childrenByMotherUuid };
return { motherByChildUuid, childrenByMotherUuid, isLoading };
}, [childrenData, motherData, isLoadingChildrenData, isLoadingMotherData]);

return relationships;
Expand Down
Loading