Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4116 use correct colours for service queue priority #1376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flosell
Copy link

@flosell flosell commented Nov 15, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

(First PR here so please let me know if I'm doing something wrong)

O3-4116 notes that priority tags in the service queue view don't have any color.

Implementers were already able to configure this, however this was probably not used frequently. So I'm guessing the intended behaviour is a default configuration that can be overwritten if necessary. This is what this PR adds.

The PR also adds support for the orange color intended for the 'urgent' priority that was still missing.

Screenshots

Screenshot 2024-11-15 at 14 59 11

Related Issue

https://openmrs.atlassian.net/browse/O3-4116

Other

I'm not very happy the way the orange color is handled: Seems like the carbon design system does not have a color 'orange' so I implemented it as a special case similar to how the tags for the header in the patient-chart are implemented. I'm also hardcoding the same color. This seems to be slightly smelly. I'm guessing this component in this color is used in a few different places so there should be a generic solution for this problem but I'm not sure how to approach it... Suggestions welcome!

Also, the issue also asks for fixing capitalization for 'Not Urgent' - I haven't looked into this yet so might be another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant