Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCM-119: Fix NPE on CohortReportFormController.onSubmit #47

Merged
merged 2 commits into from
Jan 3, 2024
Merged

RCM-119: Fix NPE on CohortReportFormController.onSubmit #47

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba8804
Fix NPE on CohortReportFormController.onSubmit
mherman22 Jan 2, 2024
6abba19
conform to conventions
mherman22 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions omod/src/main/java/org/openmrs/web/controller/report/CohortReportFormController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,11 @@ protected ModelAndView onSubmit(HttpServletRequest request, HttpServletResponse
Document xml = db.parse(new InputSource(new StringReader(
"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>" + data)));
Node node = findChild(xml, "reportSchema");

if(node == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wiki.openmrs.org/display/docs/Java+Conventions#JavaConventions-CodeStyle

return null;
}

node = findChild(node, "dataSets");
Element dsd = xml.createElement("dataSetDefinition");
dsd.setAttribute("name", "cohorts");
Expand Down
Loading