Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid division by 0 if source rate at last time step before restart w… #22

Merged
merged 1 commit into from
Nov 17, 2023
Merged

avoid division by 0 if source rate at last time step before restart w… #22

merged 1 commit into from
Nov 17, 2023

Conversation

church89
Copy link
Collaborator

This PR fixes two things:

  1. Restart a depletion simulation from a case where last timestep has 0 power was causing issue due to a zero division in _get_bos_data_from_restart
  2. If source rate is zero during a batchwise depletion simulation, avoid setting root to None but set to the previous value.

Note that the while loop at line 826 of abc.py is just temporary.

@church89
avoid division by 0 if source rate at last time step before restart w…
be05aa9 
…as at 0 power and assign root to value at previous timestep if source rate is 0
@church89 church89 merged commit c3cc452 into openmsr_develop Nov 17, 2023
1 check passed
@church89 church89 deleted the restart_from_0_source_rate branch November 17, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@church89