Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in GUI MIX field name from mimetype to format name #899

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

samalloing
Copy link
Collaborator

@samalloing samalloing commented Feb 16, 2024

Hi @carlwilson

The GUI shows Mimetype for MIX image data, according to the specifications this should be Format Name. The export in txt and XML show the correct field, but the GUI of jHove showed the wrong field name. Fixes #896

Sam

The GUI shows Mimetype for MIX image data, according to the specifications this should be Format Name. The export in txt and XML show the correct field, but the GUI of jHove showed the wrong field name. This pull request fixes #896
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (7f090b6) to head (5ea5467).
Report is 1 commits behind head on integration.

Additional details and impacted files
@@              Coverage Diff               @@
##             integration     #899   +/-   ##
==============================================
  Coverage          47.00%   47.00%           
  Complexity          1100     1100           
==============================================
  Files                 57       57           
  Lines               9079     9079           
  Branches            1622     1622           
==============================================
  Hits                4268     4268           
  Misses              4280     4280           
  Partials             531      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlwilson carlwilson merged commit c7eaf5f into openpreserve:integration Mar 4, 2024
6 checks passed
@carlwilson carlwilson added this to the JHOVE 1.30 milestone Mar 6, 2024
@leninoc
Copy link

leninoc commented Mar 12, 2024

hi, thanks for including this fix.
The fix covers PDF, PNG, GIF, JPEG, JPEG2000 and TIFF modules - I thought I would make it clear here, someone might need this detail later on, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different element name in UI and when exported as xml or txt - PDF module
3 participants