ACL Sentence Piece Model integration from master #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, I haven't had time to get to this yet, but I'll try to take a look sometime this month. It's a bit of a busy time at the moment. |
|
@neubig is there a chance you can take a look at this PR? or let us know how to test the ACL model. |
|
Hi Guys, I'm really sorry we've been so slow on this. We've been a bit occupied by running the ARR system (among other duties) and haven't had a consolidated block of time to look at this. I'll try to take a look as soon as i can though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only the code changes from #72 that is required for using the ACL model.