Skip to content

Commit

Permalink
check member for anon and nonanon groups (#1870)
Browse files Browse the repository at this point in the history
* check member for anon and nonanon groups

* increase version
  • Loading branch information
melisabok authored Oct 20, 2023
1 parent 79c73dc commit 15f4c96
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion openreview/journal/journal.py
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ def get_late_invitees(self, invitation_id):
profile = self.client.get_profile(signature)
signature_members.append(profile.id)
else:
signature_members = signature_members + signature['members']
signature_members = signature_members + self.client.get_group(signature['id']).members
for signature in reply.signatures:
if signature.startswith('~'):
profile = self.client.get_profile(signature)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
setup(
name='openreview-py',

version='1.32.0',
version='1.32.1',

description='OpenReview API Python client library',
url='https://github.com/openreview/openreview-py',
Expand Down
3 changes: 3 additions & 0 deletions tests/test_journal.py
Original file line number Diff line number Diff line change
Expand Up @@ -2278,6 +2278,9 @@ def test_submission(self, journal, openreview_client, test_client, helpers):

helpers.await_queue_edit(openreview_client, edit_id=verification_note['id'])

## check late invitees again
assert journal.get_late_invitees('TMLR/Paper1/-/Camera_Ready_Verification') == []

messages = journal.client.get_messages(to = '[email protected]', subject = '[TMLR] Camera ready version accepted for your TMLR submission 1: Paper title VERSION 2')
assert len(messages) == 1
assert messages[0]['content']['text'] == f'''Hi SomeFirstName User,
Expand Down

0 comments on commit 15f4c96

Please sign in to comment.