Skip to content

Commit

Permalink
ARR: Update Submission and Max Load Fields for April (#2076)
Browse files Browse the repository at this point in the history
* Replace resubmission field name

* Rename submission fields

* Rename maximum load

---------

Co-authored-by: Melisa Bok <[email protected]>
  • Loading branch information
haroldrubio and melisabok authored Apr 3, 2024
1 parent 0e34fb8 commit 80456ee
Show file tree
Hide file tree
Showing 5 changed files with 397 additions and 361 deletions.
6 changes: 3 additions & 3 deletions openreview/arr/management/setup_reassignment_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def replace_edge(existing_edge=None, edge_inv=None, new_weight=None, submission_
invitation=role_cmp_inv,
head=role_id,
tail=id,
weight=int(note.content['maximum_load']['value']),
weight=int(note.content['maximum_load_this_cycle']['value']),
readers=track_edge_readers[role_id] + [id],
writers=[venue_id],
signatures=[venue_id]
Expand Down Expand Up @@ -275,7 +275,7 @@ def replace_edge(existing_edge=None, edge_inv=None, new_weight=None, submission_
}
)
# Handle case where user has max load 0 but accepts resubmissions
if id_to_load_note.get(reviewer_id) and int(id_to_load_note[reviewer_id].content['maximum_load']['value']) == 0 and 'Yes' in id_to_load_note[reviewer_id].content['maximum_load_resubmission']['value']:
if id_to_load_note.get(reviewer_id) and int(id_to_load_note[reviewer_id].content['maximum_load_this_cycle']['value']) == 0 and 'Yes' in id_to_load_note[reviewer_id].content['maximum_load_this_cycle_for_resubmissions']['value']:
only_resubmissions.append({
'role': reviewers_id,
'name': reviewer_id
Expand Down Expand Up @@ -339,7 +339,7 @@ def replace_edge(existing_edge=None, edge_inv=None, new_weight=None, submission_
}
)
# Handle case where user has max load 0 but accepts resubmissions
if id_to_load_note.get(ae_id) and int(id_to_load_note[ae_id].content['maximum_load']['value']) == 0 and 'Yes' in id_to_load_note[ae_id].content['maximum_load_resubmission']['value']:
if id_to_load_note.get(ae_id) and int(id_to_load_note[ae_id].content['maximum_load_this_cycle']['value']) == 0 and 'Yes' in id_to_load_note[ae_id].content['maximum_load_this_cycle_for_resubmissions']['value']:
only_resubmissions.append({
'role': area_chairs_id,
'name': ae_id
Expand Down
2 changes: 1 addition & 1 deletion openreview/arr/management/setup_shared_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def _is_not_available(month: str, year: int, current_date: datetime.datetime, po
note.writers = [next_cycle_id, note.signatures[0]]
note.forum = next_load_invitation.edit['note']['forum']
note.replyto = next_load_invitation.edit['note']['replyto']
note.content['maximum_load'] = {'value': '0'}
note.content['maximum_load_this_cycle'] = {'value': '0'}
note.content['next_available_month'] = {'value': next_available_date[0]}
note.content['next_available_year'] = {'value': next_available_date[1]}

Expand Down
8 changes: 4 additions & 4 deletions openreview/arr/process/max_load_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def process(client, edit, invitation):
signatures=[CONFERENCE_ID],
head=role,
tail=user,
weight=int(edit.note.content['maximum_load']['value'])
weight=int(edit.note.content['maximum_load_this_cycle']['value'])
)
)

Expand All @@ -78,11 +78,11 @@ def process(client, edit, invitation):
)

availability_label = None
if 'yes' in edit.note.content['maximum_load_resubmission']['value'].lower() and int(edit.note.content['maximum_load']['value']) == 0:
if 'yes' in edit.note.content['maximum_load_this_cycle_for_resubmissions']['value'].lower() and int(edit.note.content['maximum_load_this_cycle']['value']) == 0:
availability_label = 'Only Reviewing Resubmissions'
elif 'yes' in edit.note.content['maximum_load_resubmission']['value'].lower():
elif 'yes' in edit.note.content['maximum_load_this_cycle_for_resubmissions']['value'].lower():
availability_label = 'Yes'
elif 'no' in edit.note.content['maximum_load_resubmission']['value'].lower():
elif 'no' in edit.note.content['maximum_load_this_cycle_for_resubmissions']['value'].lower():
availability_label = 'No'

client.post_edge(
Expand Down
Loading

0 comments on commit 80456ee

Please sign in to comment.