Skip to content

Commit

Permalink
Fix/ Fix more tests (#2424)
Browse files Browse the repository at this point in the history
* fix request form test

* fix v1 arr test
  • Loading branch information
celestemartinez authored Nov 13, 2024
1 parent de1b2ef commit c04a678
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
8 changes: 4 additions & 4 deletions tests/test_arr_venue.py
Original file line number Diff line number Diff line change
Expand Up @@ -1150,22 +1150,22 @@ def test_ethics_review_stage(self, venue, client, helpers):
helpers.await_queue()

## Assign a second ethics reviewer
helpers.create_user('[email protected]', 'Ethics', 'ReviewerTwo')
helpers.create_user('[email protected]', 'Ethics', 'ARRReviewerTwo')
ethics_reviewer_client = openreview.Client(username='[email protected]', password=helpers.strong_password)

ethics_chair_client.post_edge(openreview.Edge(
invitation='aclweb.org/ACL/ARR/2021/September/Ethics_Reviewers/-/Assignment',
readers=['aclweb.org/ACL/ARR/2021/September', 'aclweb.org/ACL/ARR/2021/September/Ethics_Chairs', '~Ethics_ReviewerTwo1'],
readers=['aclweb.org/ACL/ARR/2021/September', 'aclweb.org/ACL/ARR/2021/September/Ethics_Chairs', '~Ethics_ARRReviewerTwo1'],
nonreaders=['aclweb.org/ACL/ARR/2021/September/Paper5/Authors'],
writers=['aclweb.org/ACL/ARR/2021/September', 'aclweb.org/ACL/ARR/2021/September/Ethics_Chairs'],
head=submissions[0].id,
tail='~Ethics_ReviewerTwo1',
tail='~Ethics_ARRReviewerTwo1',
signatures=['aclweb.org/ACL/ARR/2021/September/Ethics_Chairs']
))

helpers.await_queue()

assert '~Ethics_ReviewerTwo1' in client.get_group('aclweb.org/ACL/ARR/2021/September/Paper5/Ethics_Reviewers').members
assert '~Ethics_ARRReviewerTwo1' in client.get_group('aclweb.org/ACL/ARR/2021/September/Paper5/Ethics_Reviewers').members
signatory_groups=client.get_groups(regex='aclweb.org/ACL/ARR/2021/September/Paper5/Ethics_Reviewer_', signatory='[email protected]')
assert len(signatory_groups) == 1

Expand Down
6 changes: 4 additions & 2 deletions tests/test_venue_request_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -2309,7 +2309,8 @@ def test_ac_identity_reveal(self, client, test_client, openreview_client, seleni
))
assert venue_revision_note

helpers.await_queue()
helpers.await_queue()
helpers.await_queue_edit(openreview_client, 'V2.cc/2030/Conference/Area_Chairs/-/Submission_Group-0-1', count=5)

anon_groups = openreview_client.get_groups(prefix='V2.cc/2030/Conference/Submission1/Area_Chair_.*')
assert len(anon_groups) == 1
Expand Down Expand Up @@ -2359,7 +2360,8 @@ def test_ac_identity_reveal(self, client, test_client, openreview_client, seleni
))
assert venue_revision_note

helpers.await_queue()
helpers.await_queue()
helpers.await_queue_edit(openreview_client, 'V2.cc/2030/Conference/Area_Chairs/-/Submission_Group-0-1', count=6)

anon_groups = openreview_client.get_groups(prefix='V2.cc/2030/Conference/Submission1/Area_Chair_.*')
assert len(anon_groups) == 1
Expand Down

0 comments on commit c04a678

Please sign in to comment.