Add ethics fields without stage (#2359)

openreview/venue/group.py

@@ -273,12 +273,16 @@ def create_venue_group(self):
         if self.venue.review_rebuttal_stage:
             content['rebuttal_email_pcs'] = { 'value': self.venue.review_rebuttal_stage.email_pcs}
 
-        if self.venue.ethics_review_stage:
+        if self.venue.use_ethics_chairs:
             content['ethics_chairs_id'] = { 'value': self.venue.get_ethics_chairs_id() }
             content['ethics_chairs_name'] = { 'value': self.venue.ethics_chairs_name }
+
+        if self.venue.use_ethics_reviewers:
             content['ethics_reviewers_name'] = { 'value': self.venue.ethics_reviewers_name }
-            content['ethics_review_name'] = { 'value': self.venue.ethics_review_stage.name }
             content['anon_ethics_reviewer_name'] = { 'value': self.venue.anon_ethics_reviewers_name() }
+
+        if self.venue.ethics_review_stage:
+            content['ethics_review_name'] = { 'value': self.venue.ethics_review_stage.name }
             content['release_submissions_to_ethics_chairs'] = { 'value': self.venue.ethics_review_stage.release_to_chairs }
 
         if venue_group.content.get('enable_reviewers_reassignment'):

tests/test_arr_venue_v2.py

@@ -270,6 +270,12 @@ def test_august_cycle(self, client, openreview_client, helpers, test_client, req
         venue = openreview.helpers.get_conference(client, request_form_note.id, 'openreview.net/Support')
         invitation_builder = openreview.arr.InvitationBuilder(venue)
 
+        domain = openreview_client.get_group('aclweb.org/ACL/ARR/2023/August')
+        assert domain.content['ethics_chairs_id']['value'] == venue.get_ethics_chairs_id()
+        assert domain.content['ethics_chairs_name']['value'] == venue.ethics_chairs_name
+        assert domain.content['ethics_reviewers_name']['value'] == venue.ethics_reviewers_name
+        assert domain.content['anon_ethics_reviewer_name']['value'] == venue.anon_ethics_reviewers_name()
+
         assert client.get_invitation(f'openreview.net/Support/-/Request{request_form_note.number}/ARR_Configuration')
 
         now = datetime.datetime.utcnow()