Skip to content

Commit

Permalink
ARR - Adjusting review feedback from (#2327)
Browse files Browse the repository at this point in the history 
* Changing the review feedback from as requested by EICs

* Clarifying review rating description

* Move tests in workflow

* Tweaks to language in the structured review feedback form

* Edited metareview form

* Edited metareview form

* Move tests in workflow

* Add autoapproval for some types of name deletion requests (#2323)

* Add autoapproval for some types of name deletion requests

* Update request_remove_name_process.py

Add return

* script to get the unavailable reviewers (#2320)

Co-authored-by: celestemartinez <[email protected]>

* Fix/Venue: Chat process and date process (#2328)

* check groups exist

* fix test

* increase package version to 1.43.1 (#2330)

* Fix: Pass program chairs group in an array (#2331)

* Fix: Pass program chairs group in an array

* increase package version

---------

Co-authored-by: Celeste Martinez <[email protected]>

* Feat/ API2 Client: add get_group_edits (#2336)

* add get_group_edits to api2 client

* let format_params take care of boolean

* Update postSubmissionProcess.py (#2333)

* Update postSubmissionProcess.py

Add a notification that the post submission stage has completed

* Update postSubmissionProcess.py

Fix formatting of message

* Update test_venue_request_v2.py

Add draft of test to issue

* Update test_icml_conference.py

* Update test_icml_conference.py

* Update test_icml_conference.py

---------

Co-authored-by: celestemartinez <[email protected]>

* Fix/tmlr requests (#2340)

* add default to pending reviews invitation

* send copy of invite email to AE

* send invite assignment reminder 1 week after invitation is sent

* Fix/ Remove DBLP Abstract process function (#2332)

* remove abstract process function

* fix test

* increase package version to 1.43.3 (#2344)

Co-authored-by: carlosmondra <[email protected]>

* Undoing unintentional edits

* Fixing unintentional edits

* Add meta review readers and rename

* Fix spelling mistake

Co-authored-by: celestemartinez <[email protected]>

* Fix spelling mistake on expdate

Co-authored-by: celestemartinez <[email protected]>

* Make fields deletable

---------

Co-authored-by: Harold Rubio <[email protected]>
Co-authored-by: emily-grabowski <[email protected]>
Co-authored-by: Melisa Bok <[email protected]>
Co-authored-by: celestemartinez <[email protected]>
Co-authored-by: carlosmondra <[email protected]>
Co-authored-by: Celeste Martinez <[email protected]>
Co-authored-by: xkopenreview <[email protected]>
Co-authored-by: Harold Rubio <[email protected]>
  • Loading branch information
@jkkummerfeld @haroldrubio
@emily-grabowski @melisabok @celestemartinez @carlosmondra @xkopenreview
9 people authored Nov 12, 2024
1 parent 7718f16 commit e24dcd5
Show file tree
Hide file tree
Showing 3 changed files with 247 additions and 217 deletions.
68 changes: 58 additions & 10 deletions openreview/arr/helpers.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,14 @@ class ARRWorkflow(object):
"order": 37,
"required": False
},
"review_rating_start_date": {
"description": "When should the review rating form open?",
"review_issue_start_date": {
"description": "When should the form for authors to make structured complaints to ACs about reviews open?",
"value-regex": "^[0-9]{4}\\/([1-9]|0[1-9]|1[0-2])\\/([1-9]|0[1-9]|[1-2][0-9]|3[0-1])(\\s+)?((2[0-3]|[01][0-9]|[0-9]):[0-5][0-9])?(\\s+)?$",
"order": 38,
"required": False
},
"review_rating_exp_date": {
"description": "When should the review rating form close?",
"review_issue_exp_date": {
"description": "When should the form for authors to make structured complaints to ACs about reviews close?",
"value-regex": "^[0-9]{4}\\/([1-9]|0[1-9]|1[0-2])\\/([1-9]|0[1-9]|[1-2][0-9]|3[0-1])(\\s+)?((2[0-3]|[01][0-9]|[0-9]):[0-5][0-9])?(\\s+)?$",
"order": 39,
"required": False
Expand Down Expand Up @@ -870,23 +870,24 @@ def __init__(self, client_v2, venue, configuration_note, request_form_id, suppor
),
ARRStage(
type=ARRStage.Type.CUSTOM_STAGE,
required_fields=['review_rating_start_date', 'review_rating_exp_date'],
required_fields=['review_issue_start_date', 'review_issue_exp_date'],
super_invitation_id=f"{self.venue_id}/-/Review_Rating",
stage_arguments={
'name': 'Review_Rating',
'name': 'Review_Issue_Report',
'reply_to': openreview.stages.CustomStage.ReplyTo.REVIEWS,
'source': openreview.stages.CustomStage.Source.ALL_SUBMISSIONS,
'invitees': [openreview.stages.CustomStage.Participants.AUTHORS],
'readers': [
openreview.stages.CustomStage.Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
openreview.stages.CustomStage.Participants.AREA_CHAIRS_ASSIGNED
openreview.stages.CustomStage.Participants.AREA_CHAIRS_ASSIGNED,
openreview.stages.CustomStage.Participants.SIGNATURES
],
'content': arr_review_rating_content,
'notify_readers': False,
'email_sacs': False
},
start_date=self.configuration_note.content.get('review_rating_start_date'),
exp_date=self.configuration_note.content.get('review_rating_exp_date')
start_date=self.configuration_note.content.get('review_issue_start_date'),
exp_date=self.configuration_note.content.get('review_issue_exp_date')
),
ARRStage(
type=ARRStage.Type.STAGE_NOTE,
Expand Down Expand Up @@ -1196,6 +1197,53 @@ class Participants(Enum):
'Blind_Submission_License_Agreement': 'Submission_Revision_Stage'
}
FIELD_READERS = {
'Meta_Review': {
'content_name': 'additional_meta_review_form_options',
'fields': {
'reported_issues': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED,
Participants.AUTHORS
],
'note_to_authors': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED,
Participants.AUTHORS
],
'best_paper_ae': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'best_paper_ae_justification': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'ethical_concerns': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'needs_ethics_review': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'author_identity_guess': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'great_reviews': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'poor_reviews': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
'explanation': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED
],
}
}
}
UPDATE_WAIT_TIME = 5
PROCESS_LOG_TIMEOUT = 360 # 360 iterations for 30 minutes total
Expand Down Expand Up @@ -1718,4 +1766,4 @@ def get_resubmissions(submissions, previous_url_field):
return list(filter(
lambda s: previous_url_field in s.content and 'value' in s.content[previous_url_field] and len(s.content[previous_url_field]['value']) > 0,
submissions
))
))
Loading

0 comments on commit e24dcd5

Please sign in to comment.