Avoid potential for StackOverflow on J#getWeight (#4343)

openrewrite · Jul 19, 2024 · 105bdab · 105bdab
1 parent 537d023
commit 105bdab
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/rewrite-java/src/main/java/org/openrewrite/java/tree/J.java b/rewrite-java/src/main/java/org/openrewrite/java/tree/J.java
@@ -1528,11 +1528,9 @@ public JavaType visit(@Nullable JavaType javaType, AtomicInteger n) {
                 };
 
                 @Override
-                public @Nullable J visit(@Nullable Tree tree, AtomicInteger n) {
-                    if (tree != null) {
-                        n.incrementAndGet();
-                    }
-                    return super.visit(tree, n);
+                public @Nullable J preVisit(J tree, AtomicInteger n) {
+                    n.incrementAndGet();
+                    return tree;
                 }
 
                 @Override