Parser does not handle annotated varargs correctly

[Laurens-W]

What's changed?

Added reproducer testcase

What's your motivation?

• Parser: not idempotent on annotated varargs #3881

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[traceyyoshima]

As a sanity check, I suggest looking at a few things:

1. The Java type of typeExpression on J.AnnotatedType.
2. If the solution will apply to code like void m ( String @NonNull [ ] @NonNull ... s ) { }

[timtebeek]

Thanks for the helpful counter example @traceyyoshima ! That indeed still fails; when I revert the printer changes I see:

diff --git a/C2.java b/C2.java
index 2b026e1..326aa32 100644
--- a/C2.java
+++ b/C2.java
@@ -1,6 +1,6 @@ 
 import org.jspecify.annotations.NonNull;
 
 class C2 {
-    void m(@NonNull String @NonNull ... varArgs) {
+    void m(@NonNull String @NonNull[] ... varArgs) {
     }
 }

diff --git a/C3.java b/C3.java
index 108e4b9..389aba9 100644
--- a/C3.java
+++ b/C3.java
@@ -1,6 +1,6 @@ 
 import org.jspecify.annotations.NonNull;
 
 class C3 {
-    void m(String @NonNull [ ] @NonNull ... s) {
+    void m(String @NonNull [ ] ... s) {
     }
 }

[github-actions]

Suggested change

	J.AnnotatedType annotatedType = new J.AnnotatedType(randomId(), fmt, Markers.EMPTY, leadingAnnotations, arrayTypeTree(node, annotationPosTable));
	// if (((JCArrayTypeTree) node.getUnderlyingType()).getType() instanceof JCAnnotatedType) {
	// visitAnnotatedType((AnnotatedTypeTree) ((JCArrayTypeTree) node.getUnderlyingType()).getType(), fmt);
	// if (((JCArrayTypeTree) node.getUnderlyingType()).getType() instanceof JCAnnotatedType) {
	return new J.AnnotatedType(randomId(), fmt, Markers.EMPTY, leadingAnnotations, arrayTypeTree(node, annotationPosTable));