Update GitRemote#normalize to support organizations prefixed with a number
#4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryceatmoderne
changed the title
GitRemote#normalize to support organizations prefixed with a number
pstreef
reviewed
Nov 6, 2024
| @@ -279,7 +279,7 @@ private String repositoryPath(RemoteServerMatch match, URI normalizedUri) { | |||
| .replaceFirst("^/", ""); | |||
| } | |||
|
|
|||
| private static final Pattern PORT_PATTERN = Pattern.compile(":\\d+"); | |||
| private static final Pattern PORT_PATTERN = Pattern.compile(":\\d+/"); | |||
There was a problem hiding this comment.
what if the org is a number 🤔
There was a problem hiding this comment.
Well at least github supports number-only orgs. (https://github.com/1234)
…ewrite/rewrite into git-remote-orgs-with-number-prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
GitRemote#normalizewas incorrectly identifying an organization starting with a number, such1org, as a port number. These changes update the regexPatternto match a numerical string up to a forward slash.What's your motivation?
Some repositories such as https://github.com/1Remote/1Remote were failing to build using the Moderne CLI.
Anything in particular you'd like reviewers to focus on?
No
Anyone you would like to review specifically?
@pstreef
Have you considered any alternatives or workarounds?
No
Any additional context
No
Checklist