Introduce scoped variable trait #4682
Draft
+189
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| import org.openrewrite.trait.Trait; | ||
|
|
||
| @Value | ||
| public class ScopedVariable implements Trait<J.VariableDeclarations.NamedVariable> { |
There was a problem hiding this comment.
If we want to support instanceof pattern matching, then we won't be able to use NamedVariable as the generic type parameter but would instead have to use J for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a trait to pull together the scope and identifier of
NamedVariables and added testcases to showcase its usageAnyone you would like to review specifically?
@sambsnyd @timtebeek
Any additional context
Continued from
ScopedVariabletrait rewrite-migrate-java#604Checklist