Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter by global role shows roles that aren't global #4632

Closed
lucyb opened this issue Sep 30, 2024 · 0 comments · Fixed by #4728
Closed

Filter by global role shows roles that aren't global #4632

lucyb opened this issue Sep 30, 2024 · 0 comments · Fixed by #4728
Assignees
@mikerkelly @KatieB5
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lucyb
Copy link
Contributor

lucyb commented Sep 30, 2024 •
edited
Loading

When I go to the Users page in the Staff Area and select the "Filter by global role" option, the dropdown box shows all roles rather than just the roles that can be globally assigned.

For example, ProjectDeveloper can only be assigned to a user on a project. It cannot be assigned globally, so should not be in this list.

Image
@lucyb lucyb added bug Something isn't working good first issue Good for newcomers labels Sep 30, 2024
KatieB5 added a commit that referenced this issue Nov 5, 2024
@KatieB5
Actually filter by global roles
9d81123 
Fixes #4632
Previously the Users page in the Staff Area had a "Filter by global roles" option which displayed all roles rather than just globally assignable roles.
This commit added a global_roles module so that the view does not need to know the details of the implementation.
KatieB5 added a commit that referenced this issue Nov 8, 2024
@KatieB5
Filter by global roles
febce2f 
Fixes #4632

Previously the Users page in the Staff Area had a "Filter by global roles" option which displayed all roles rather than just globally assignable roles. This commit adds a `global_roles` module so that the view does not need to know the details of the implementation.
@KatieB5 KatieB5 mentioned this issue Nov 8, 2024
Merged
@iaindillingham iaindillingham mentioned this issue Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikerkelly mikerkelly

@KatieB5 KatieB5

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter by global roles opensafely-core/job-server
4 participants
@iaindillingham @lucyb @mikerkelly @KatieB5