Filter by global roles #4728
Merged
Filter by global roles #4728
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4632 Previously the Users page in the Staff Area had a "Filter by global roles" option which displayed all roles rather than just globally assignable roles. This commit adds a `global_roles` module so that the view does not need to know the details of the implementation.
mikerkelly
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks Katie.
Katie and I paired on this ticket apart from writing the test.
I noticed the unit test includes an explicit list of expected role names. This made me wonder if the GLOBAL_ROLES definition could simply use the same list instead of being generated by roles_for. However, I think it's beneficial to have both approaches—one in the code and one in the test—for better verification. The minor downside is needing to update the test whenever GLOBAL_ROLES changes.
KatieB5
deleted the
KatieB5/filter-by-global-role-shows-roles-that-arent-global
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4632
Previously the Users page in the Staff Area had a "Filter by global roles" option which displayed all roles rather than just globally assignable roles. This commit adds a
global_rolesmodule so that the view does not need to know the details of the implementation.