Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve horizontal scrolling performance of the headers row in tables #167

Merged

Conversation

jpovixwm
Copy link
Contributor

demo
It should be noted that toRefProxy and fromRefProxy are probably overkill, because they only make a difference if either the headers row or the torrent-table-rows container are re-mounted independently of each other, which I don't think could ever happen here. But it doesn't hurt to have this, as it makes makes the implementation a bit more future proof.
The idea is that if e.g. the <Box> component was unmounted and re-mounted, it wouldn't receive the initial translate styles. This can be simulated by providing a key to the <Box> component; whenever the key changes, the old Box is destroyed, and a new one is mounted in its place, triggering the callback ref.

@qu1ck qu1ck merged commit 626eb2a into openscopeproject:master Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants