Improve horizontal scrolling performance of the headers row in tables #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be noted that
toRefProxy
andfromRefProxy
are probably overkill, because they only make a difference if either the headers row or thetorrent-table-rows
container are re-mounted independently of each other, which I don't think could ever happen here. But it doesn't hurt to have this, as it makes makes the implementation a bit more future proof.The idea is that if e.g. the
<Box>
component was unmounted and re-mounted, it wouldn't receive the initialtranslate
styles. This can be simulated by providing akey
to the<Box>
component; whenever the key changes, the old Box is destroyed, and a new one is mounted in its place, triggering the callback ref.