Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace]Fix/UI of assets table #8519

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Oct 8, 2024

Description

This pr addresses the UI of assets table by:

  1. Show a couple of workspace names + a badge "+ N more" showing a popover with the rest of the list of the workspaces(To adjust UI and unstable workspace name length, only one workspace name will he shown)
  2. Add "database" icon for the assets of the type "Data source"
  3. Add "Gear" icon to the config type assets
  4. Is there are no workspaces, show mdash in the table cell

Screenshot

截屏2024-10-08 08 10 39 截屏2024-10-08 09 49 37

Changelog

  • fix: UI of assets table

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (98df4dd) to head (4dab27a).

Files with missing lines Patch % Lines
...agement_section/objects_table/components/table.tsx 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8519      +/-   ##
==========================================
+ Coverage   60.93%   60.94%   +0.01%     
==========================================
  Files        3769     3769              
  Lines       89506    89525      +19     
  Branches    14012    14016       +4     
==========================================
+ Hits        54539    54560      +21     
  Misses      31557    31557              
+ Partials     3410     3408       -2     
Flag Coverage Δ
Linux_1 28.99% <0.00%> (-0.01%) ⬇️
Linux_2 56.25% <ø> (ø)
Linux_3 37.74% <0.00%> (-0.01%) ⬇️
Linux_4 29.94% <85.71%> (+0.02%) ⬆️
Windows_1 29.01% <0.00%> (-0.01%) ⬇️
Windows_2 56.20% <ø> (ø)
Windows_3 37.74% <0.00%> (-0.02%) ⬇️
Windows_4 29.94% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants