-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote State] Upload incremental cluster state on master re-election #15145
Conversation
❌ Gradle check result for 9710a15: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15145-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbdcbb7da3d87fdccfca164ac8f6914a55dc19cb
# Push it to GitHub
git push --set-upstream origin backport/backport-15145-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15145-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbdcbb7da3d87fdccfca164ac8f6914a55dc19cb
# Push it to GitHub
git push --set-upstream origin backport/backport-15145-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17 Then, create a pull request where the |
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit cbdcbb7)
…ster re-election (#15145) (#15792) * [Remote State] Upload incremental cluster state on master re-election (#15145) Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit cbdcbb7)
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit cbdcbb7)
…#15145) (#15853) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]> (cherry picked from commit cbdcbb7)
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]>
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]>
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]>
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <[email protected]>
Description
Currently we upload full cluster state when master re-election happens. This can lead to un-neccessary upload of cluster state attributes even if no change is there in the cluster state attributes. If the cluster has lots of indices or other state metadata. Uploading state every time a node is trying to get elected as cluster manager, the overhead of uploading the cluster state can be big and can problems like S3 throttling or election loop.
Also, when we receive a publication request on a node where the Remote Publication is marked as enabled, but the publication is from Transport channel, we reset the last accepted state and manifest in our RemotePersistedState object to avoid any stale value being persisted on the nodes. Now if these nodes try to become cluster manager, they will be uploading the full state, which rather than uploading a diff from stale state.
Related Issues
Resolves #10682
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.