Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes of #15409 #15624

Merged

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Sep 3, 2024

Description

Fix breaking changes of #15409
Screenshot 2024-09-03 at 11 39 39 PM

Related Issues

Resolves #15463

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.17.0 labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for 8e83f3a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@ltaragi
Copy link
Contributor Author

ltaragi commented Sep 3, 2024

❕ Gradle check result for 8e83f3a: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky tests #14294

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.77%. Comparing base (7a9cb35) to head (8e83f3a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15624      +/-   ##
============================================
- Coverage     71.83%   71.77%   -0.06%     
+ Complexity    63932    63920      -12     
============================================
  Files          5258     5258              
  Lines        299329   299358      +29     
  Branches      43259    43260       +1     
============================================
- Hits         215010   214872     -138     
- Misses        66587    66816     +229     
+ Partials      17732    17670      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltaragi ltaragi requested a review from VachaShah as a code owner September 3, 2024 19:10
@Bukhtawar Bukhtawar merged commit a60b668 into opensearch-project:main Sep 3, 2024
61 of 62 checks passed
@Bukhtawar Bukhtawar added the backport 2.x Backport to 2.x branch label Sep 3, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15624-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a60b668ad98a52ee8e42ace52de3f68caff36276
# Push it to GitHub
git push --set-upstream origin backport/backport-15624-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15624-to-2.x.

ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 3, 2024
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
ashking94 pushed a commit that referenced this pull request Sep 4, 2024
* [SnapshotV2] Snapshot Status API changes (#15409)

---------

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 925f41b)

* Remove breaking changes from #15409 (#15624)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit a60b668)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
…ct#15624 to 2.x (opensearch-project#15595)

* [SnapshotV2] Snapshot Status API changes (opensearch-project#15409)

---------

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 925f41b)

* Remove breaking changes from opensearch-project#15409 (opensearch-project#15624)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)
ltaragi added a commit to ltaragi/OpenSearch that referenced this pull request Sep 4, 2024
…ct#15624 to 2.x (opensearch-project#15595)

* [SnapshotV2] Snapshot Status API changes (opensearch-project#15409)

---------

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 925f41b)

* Remove breaking changes from opensearch-project#15409 (opensearch-project#15624)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)
sachinpkale pushed a commit that referenced this pull request Sep 4, 2024
---------

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 925f41b)

* Remove breaking changes from #15409 (#15624)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit a60b668)
(cherry picked from commit 01b38be)

* Change version to V_2_17_0 (#15596) (#15642)

Signed-off-by: Lakshya Taragi <[email protected]>
(cherry picked from commit 0f53bf9)
(cherry picked from commit d368e3b)
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Snapshots v2.17.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[SnapshotV2] Snapshot Status API changes
2 participants