Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set the include discovery nodes flag for reload secure set… #15972

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Explicitly set the include discovery nodes flag for reload secure set… #15972

merged 2 commits into from
Sep 19, 2024

Conversation

SwethaGuptha
Copy link
Contributor

…ting request

Description

Explicitly setting the include discovery nodes flag for reload secure setting request, so that the behavior of the action remains same when the default value is changed.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SwethaGuptha SwethaGuptha force-pushed the explicitly-set-concrete-nodes-flag-in-secure-setting-action branch from 268dbaf to 079940c Compare September 18, 2024 05:12
@SwethaGuptha SwethaGuptha marked this pull request as ready for review September 18, 2024 05:13
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 268dbaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 079940c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shwetathareja shwetathareja added skip-changelog backport 2.x Backport to 2.x branch labels Sep 18, 2024
@SwethaGuptha
Copy link
Contributor Author

❌ Gradle check result for 079940c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test #15812

@SwethaGuptha SwethaGuptha force-pushed the explicitly-set-concrete-nodes-flag-in-secure-setting-action branch from 079940c to 3e70fc2 Compare September 18, 2024 06:44
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3e70fc2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha
Copy link
Contributor Author

❌ Gradle check result for 3e70fc2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test #14311

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 17, 2024
Open
dbwiddis
dbwiddis approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but I'm missing the context of this. Is there a bug/issue documenting why it is needed?

@SwethaGuptha SwethaGuptha force-pushed the explicitly-set-concrete-nodes-flag-in-secure-setting-action branch from 3e70fc2 to 1bb8a65 Compare September 18, 2024 21:52
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1bb8a65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 19, 2024
Open
@SwethaGuptha
Copy link
Contributor Author

Code LGTM but I'm missing the context of this. Is there a bug/issue documenting why it is needed?

This is in continuation to the PR #15131.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1bb8a65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the explicitly-set-concrete-nodes-flag-in-secure-setting-action branch from 1bb8a65 to 3811ea6 Compare September 19, 2024 06:33
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3811ea6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for a931a05: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.97%. Comparing base (3937ccb) to head (a931a05).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../node/reload/NodesReloadSecureSettingsRequest.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15972      +/-   ##
============================================
+ Coverage     71.90%   71.97%   +0.06%     
+ Complexity    64392    64338      -54     
============================================
  Files          5278     5278              
  Lines        300877   300877              
  Branches      43478    43478              
============================================
+ Hits         216351   216550     +199     
+ Misses        66747    66530     -217     
- Partials      17779    17797      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SwethaGuptha
Copy link
Contributor Author

❕ Gradle check result for a931a05: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test #14289

@shwetathareja shwetathareja merged commit 620db0a into opensearch-project:main Sep 19, 2024
32 of 34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2024
@github-actions
Explicitly set include discovery nodes flag in reloadSecureSetting re…
c8bfff9 
…quest. (#15972)

Signed-off-by: Swetha Guptha <[email protected]>
(cherry picked from commit 620db0a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 19, 2024
Merged
This was referenced Sep 19, 2024
Open
Open
@SwethaGuptha SwethaGuptha mentioned this pull request Sep 19, 2024
Open
3 tasks
amberzsy pushed a commit to amberzsy/OpenSearch-public that referenced this pull request Sep 22, 2024
@SwethaGuptha @amberzsy
Explicitly set include discovery nodes flag in reloadSecureSetting re…
6fbfd12 
…quest. (opensearch-project#15972)

Signed-off-by: Swetha Guptha <[email protected]>
shwetathareja pushed a commit that referenced this pull request Sep 23, 2024
@opensearch-trigger-bot
Explicitly set include discovery nodes flag in reloadSecureSetting re…
6bc4071 
…quest. (#15972) (#15992)

(cherry picked from commit 620db0a)

Signed-off-by: Swetha Guptha <[email protected]>
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@SwethaGuptha @dk2k
Explicitly set include discovery nodes flag in reloadSecureSetting re…
3e63fb2 
…quest. (opensearch-project#15972)

Signed-off-by: Swetha Guptha <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@SwethaGuptha @dk2k
Explicitly set include discovery nodes flag in reloadSecureSetting re…
5b04daf 
…quest. (opensearch-project#15972)

Signed-off-by: Swetha Guptha <[email protected]>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@SwethaGuptha @dk2k
Explicitly set include discovery nodes flag in reloadSecureSetting re…
fc59100 
…quest. (opensearch-project#15972)

Signed-off-by: Swetha Guptha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwethaGuptha @shwetathareja @dbwiddis