Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task cancellation API version guard fix #7712

Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented May 23, 2023

Description

Fixing version guard for #7445
Backport 2.x PR - #7711

Related Issues

#6953

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sgup432
Copy link
Contributor Author

sgup432 commented May 23, 2023

@andrross
@dblock

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=tasks.list/10_basic/tasks_list test}

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7712 (1339c9e) into main (c659d04) will increase coverage by 0.26%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7712      +/-   ##
============================================
+ Coverage     70.88%   71.15%   +0.26%     
- Complexity    56211    56452     +241     
============================================
  Files          4680     4680              
  Lines        266083   266083              
  Branches      39074    39074              
============================================
+ Hits         188608   189321     +713     
+ Misses        61468    61026     -442     
+ Partials      16007    15736     -271     
Impacted Files Coverage Δ
...r/src/main/java/org/opensearch/tasks/TaskInfo.java 90.62% <0.00%> (ø)

... and 436 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 70b109d into opensearch-project:main May 24, 2023
dblock pushed a commit to dblock/OpenSearch that referenced this pull request May 25, 2023
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants