Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context aware alert analysis #996

Merged

Conversation

songkant-aws
Copy link
Contributor

@songkant-aws songkant-aws commented Jul 15, 2024

Description

Context aware alert analysis implementation in alerts dashboard by leveraging existing IncontextInsight 'GeneratePopover' component

In-context prompting for alerts entry point:
Screenshot 2024-07-12 at 14 28 18
In-context prompting generating process:
Screenshot 2024-07-12 at 14 28 23
In-context prompting showing summary result with option to continue the conversation in chat:
Screenshot 2024-07-12 at 14 28 06

Issues Resolved

#995

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xluo-aws
Copy link
Member

Can some maintainers help review this ticket and add tag 2.17?

public/pages/Home/Home.js Outdated Show resolved Hide resolved
amsiglan
amsiglan previously approved these changes Sep 3, 2024
amsiglan
amsiglan previously approved these changes Sep 17, 2024
@riysaxen-amzn
Copy link
Collaborator

let's wait for the CI to pass before merging

@amsiglan amsiglan merged commit 6dbdc2e into opensearch-project:main Sep 18, 2024
9 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* support date_nanos type

Signed-off-by: Hailong Cui <[email protected]>

* support context aware alert analysis

Signed-off-by: Hailong Cui <[email protected]>

* Register summary generation type of IncontextInsight for alert summarization

Signed-off-by: Songkan Tang <[email protected]>

* Fix dashboard unit test failure

Signed-off-by: Songkan Tang <[email protected]>

* Make each alert register its own IncontextInsight

Signed-off-by: Songkan Tang <[email protected]>

* Enable context aware alert only if feature flag is enabled

Signed-off-by: Songkan Tang <[email protected]>

* Avoid unnecessary change and minorly change summary question

Signed-off-by: Songkan Tang <[email protected]>

* Fix undefined alert name

Signed-off-by: Songkan Tang <[email protected]>

* Pass monitor type to additional info object of contextProvider

Signed-off-by: Songkan Tang <[email protected]>

* Address some comments and change feature flag

Signed-off-by: Songkan Tang <[email protected]>

* Add assistant capabilities check to control component rendering

Signed-off-by: Songkan Tang <[email protected]>

* Fix mismatched unit test snapshots

Signed-off-by: Songkan Tang <[email protected]>

* Handle the edge case of multiple indices in search and return more information in additionalInfo

Signed-off-by: Songkan Tang <[email protected]>

* Reduce llm context input size by taking topN active alerts

Signed-off-by: Songkan Tang <[email protected]>

* Distinguish source data and aggregation that trigger the alert

Signed-off-by: Songkan Tang <[email protected]>

* Rename the capability UI rendering flag per assistant plugin change

Signed-off-by: Songkan Tang <[email protected]>

* Remove alert sample data per current requirement from context

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 6dbdc2e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 19, 2024
* support date_nanos type



* support context aware alert analysis



* Register summary generation type of IncontextInsight for alert summarization



* Fix dashboard unit test failure



* Make each alert register its own IncontextInsight



* Enable context aware alert only if feature flag is enabled



* Avoid unnecessary change and minorly change summary question



* Fix undefined alert name



* Pass monitor type to additional info object of contextProvider



* Address some comments and change feature flag



* Add assistant capabilities check to control component rendering



* Fix mismatched unit test snapshots



* Handle the edge case of multiple indices in search and return more information in additionalInfo



* Reduce llm context input size by taking topN active alerts



* Distinguish source data and aggregation that trigger the alert



* Rename the capability UI rendering flag per assistant plugin change



* Remove alert sample data per current requirement from context



---------




(cherry picked from commit 6dbdc2e)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Sep 19, 2024
* support date_nanos type

Signed-off-by: Hailong Cui <[email protected]>

* support context aware alert analysis

Signed-off-by: Hailong Cui <[email protected]>

* Register summary generation type of IncontextInsight for alert summarization

Signed-off-by: Songkan Tang <[email protected]>

* Fix dashboard unit test failure

Signed-off-by: Songkan Tang <[email protected]>

* Make each alert register its own IncontextInsight

Signed-off-by: Songkan Tang <[email protected]>

* Enable context aware alert only if feature flag is enabled

Signed-off-by: Songkan Tang <[email protected]>

* Avoid unnecessary change and minorly change summary question

Signed-off-by: Songkan Tang <[email protected]>

* Fix undefined alert name

Signed-off-by: Songkan Tang <[email protected]>

* Pass monitor type to additional info object of contextProvider

Signed-off-by: Songkan Tang <[email protected]>

* Address some comments and change feature flag

Signed-off-by: Songkan Tang <[email protected]>

* Add assistant capabilities check to control component rendering

Signed-off-by: Songkan Tang <[email protected]>

* Fix mismatched unit test snapshots

Signed-off-by: Songkan Tang <[email protected]>

* Handle the edge case of multiple indices in search and return more information in additionalInfo

Signed-off-by: Songkan Tang <[email protected]>

* Reduce llm context input size by taking topN active alerts

Signed-off-by: Songkan Tang <[email protected]>

* Distinguish source data and aggregation that trigger the alert

Signed-off-by: Songkan Tang <[email protected]>

* Rename the capability UI rendering flag per assistant plugin change

Signed-off-by: Songkan Tang <[email protected]>

* Remove alert sample data per current requirement from context

Signed-off-by: Songkan Tang <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Songkan Tang <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants