Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Improve GetAnomalyDetectorTransportAction to accept generic ActionRequest (#1150) #1151

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ohltyler
Copy link
Member

Description

Manual backport of #1150 due to conflict with imports. No logic changes.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler changed the title [Backport 2.x] Add ser/deser to get AD transport action request (#1150) [Backport 2.x] Improve GetAnomalyDetectorTransportAction to accept generic ActionRequest (#1150) Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b26c6c8) 79.73% compared to head (5532439) 79.80%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1151      +/-   ##
============================================
+ Coverage     79.73%   79.80%   +0.06%     
- Complexity     4357     4366       +9     
============================================
  Files           309      309              
  Lines         18170    18179       +9     
  Branches       1909     1909              
============================================
+ Hits          14488    14507      +19     
+ Misses         2772     2764       -8     
+ Partials        910      908       -2     
Flag Coverage Δ
plugin 79.80% <22.22%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...d/transport/GetAnomalyDetectorTransportAction.java 75.90% <100.00%> (+0.14%) ⬆️
...search/ad/transport/GetAnomalyDetectorRequest.java 84.31% <12.50%> (-13.37%) ⬇️

... and 6 files with indirect coverage changes

@dbwiddis dbwiddis merged commit 833bba0 into opensearch-project:2.x Jan 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants