Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Inject NamedWriteableRegistry in AD node client #1165

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 1507dd4 from #1164.

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 1507dd4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8e59cef) 79.65% compared to head (fabe848) 79.79%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1165      +/-   ##
============================================
+ Coverage     79.65%   79.79%   +0.14%     
- Complexity     4356     4364       +8     
============================================
  Files           309      309              
  Lines         18178    18182       +4     
  Branches       1909     1909              
============================================
+ Hits          14480    14509      +29     
+ Misses         2787     2759      -28     
- Partials        911      914       +3     
Flag Coverage Δ
plugin 79.79% <88.88%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ensearch/ad/client/AnomalyDetectionNodeClient.java 100.00% <100.00%> (ø)
...earch/ad/transport/GetAnomalyDetectorResponse.java 87.15% <80.00%> (+5.84%) ⬆️

... and 4 files with indirect coverage changes

@ohltyler
Copy link
Member

Only failure is spotless for java 11.

@ohltyler ohltyler merged commit d22bc87 into 2.x Feb 22, 2024
34 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants