Increase Tree Count to 50 & Update Memory Calculation for RCF models #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaituo
requested review from
jmazanec15,
jngz-es,
saratvemulapalli,
ohltyler,
vamshin,
VijayanB,
ylwu-amzn,
amitgalitz,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Signed-off-by: Kaituo Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1181 +/- ##
============================================
- Coverage 80.54% 80.53% -0.01%
- Complexity 4599 4601 +2
============================================
Files 336 336
Lines 19091 19119 +28
Branches 1987 1993 +6
============================================
+ Hits 15377 15398 +21
- Misses 2769 2772 +3
- Partials 945 949 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
changed the title
| * numberOfTrees * dimension * 4 * averagePointStoreUsage + 77192); | ||
| long thresholdSize = 6 * (dimension * 8 + 16) + shingleSize * 8 + 624; | ||
| return compactRcfSize + thresholdSize; | ||
| int pointStoreCapacity = Math.max(sampleSize * numberOfTrees + 1, 2 * sampleSize); |
There was a problem hiding this comment.
nit: sampleSize * numberOfTrees are calculated multiple times, maybe consider storing this in a variable if it doesn't change
jackiehanyang
previously approved these changes
Apr 3, 2024
Signed-off-by: Kaituo Li <[email protected]>
jackiehanyang
approved these changes
Apr 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
…1181) * Parameter tuning Signed-off-by: Kaituo Li <[email protected]> * reuse capacity calculation Signed-off-by: Kaituo Li <[email protected]> --------- Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit e9a3782) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaituo
pushed a commit
that referenced
this pull request
Apr 5, 2024
…1181) (#1186) * Parameter tuning * reuse capacity calculation --------- (cherry picked from commit e9a3782) Signed-off-by: Kaituo Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accomplishes two main objectives:
Methodology for Memory Calculation:
The updated memory calculation follows the methodology in PR #222. It involves running TRCF or RCFCaster with one million data points and measuring object sizes using jmap memory dumps. This white-box approach examines all fields listed under the heap dump to account for various scenarios, such as fluctuations in node store size due to parameter changes. Additionally, the point store ratio adjustment is based on shingle size, using a heuristic constant derived from empirical data.
Experimental Validation:
The memory size formula's accuracy was validated through experiments, with results showing a close match between estimated and actual memory usage, within a tolerable variance. Detailed experiment data can be found here:
Testing done:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.