Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Bump RCF Version and Fix Default Rules Bug in AnomalyDetector #1335

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 2ab6dc7 from #1334.

* Updated RCF version to the latest release.
* Fixed a bug in AnomalyDetector where default rules were not applied when the user provided an empty ruleset.

Testing:
* Added unit tests to cover the bug fix

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 2ab6dc7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (1a8da83) to head (a9538b0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1335      +/-   ##
============================================
+ Coverage     79.64%   79.78%   +0.13%     
- Complexity     5638     5641       +3     
============================================
  Files           533      533              
  Lines         23411    23411              
  Branches       2323     2323              
============================================
+ Hits          18646    18678      +32     
+ Misses         3663     3631      -32     
  Partials       1102     1102              
Flag Coverage Δ
plugin 79.78% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../java/org/opensearch/ad/model/AnomalyDetector.java 86.33% <100.00%> (ø)
...n/java/org/opensearch/timeseries/JobProcessor.java 82.78% <ø> (ø)
...ensearch/timeseries/ratelimit/ColdStartWorker.java 91.07% <100.00%> (ø)
...timeseries/rest/handler/IndexJobActionHandler.java 89.27% <ø> (+1.71%) ⬆️
...s/transport/handler/ResultBulkIndexingHandler.java 95.83% <100.00%> (+19.44%) ⬆️

... and 9 files with indirect coverage changes

@kaituo kaituo closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant