Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AD to time series analytics & Resolve Compiler Errors #951

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Rename AD to time series analytics & Resolve Compiler Errors #951

merged 1 commit into from
Jul 17, 2023

Commits on Jul 13, 2023

  1. Rename AD to time series analytics & Resolve Compiler Errors 

    This commit focuses on renaming the AnomalyDetectorPlugin to TimeSeriesAnalyticsPlugin as well as addressing compiler errors due to package import changes. The primary transformations are:

* Renamed AnomalyDetectorPlugin to TimeSeriesAnalyticsPlugin.
* Updated all references from AnomalyDetectorPlugin to TimeSeriesAnalyticsPlugin.
* Amended plugin information in build.gradle and src/main/resources/es-plugin.properties.
* Switched job type in TimeSeriesAnalyticsPlugin from opendistro_anomaly_detector to opensearch_time_series_analytics.

These changes led to the modification of our plugin binary from opensearch-anomaly-detection-3.0.0.0-SNAPSHOT.jar to opensearch-time-series-analytics-3.0.0.0-SNAPSHOT.jar.

Moreover, following changes from OpenSearch Pull Request #8157, compiler errors were encountered, which were resolved by updating the import packages

* org.opensearch.common.io.stream.NamedWriteableRegistry => org.opensearch.core.common.io.stream.NamedWriteableRegistry
* org.opensearch.common.xcontent.XContentParserUtils => * org.opensearch.core.xcontent.XContentParserUtils
* org.opensearch.common.bytes.BytesArray => org.opensearch.core.common.bytes.BytesArray * org.opensearch.common.io.stream.StreamInput => * org.opensearch.core.common.io.stream.StreamInput ** org.opensearch.common.io.stream.StreamOutput => org.opensearch.core.common.io.stream.StreamOutput
* org.opensearch.common.io.stream.Writeable => org.opensearch.core.common.io.stream.Writeable
* org.opensearch.common.io.stream.NotSerializableExceptionWrapper => org.opensearch.core.common.io.stream.NotSerializableExceptionWrapper
* org.opensearch.rest.RestStatus => org.opensearch.core.rest.RestStatus
* org.opensearch.common.ParsingException => org.opensearch.core.common.ParsingException
* org.opensearch.common.bytes.BytesReference => org.opensearch.core.common.bytes.BytesReference
* org.opensearch.common.io.stream.InputStreamStreamInput => org.opensearch.core.common.io.stream.InputStreamStreamInput
* org.opensearch.common.io.stream.OutputStreamStreamOutput => org.opensearch.core.common.io.stream.OutputStreamStreamOutput
* org.opensearch.index.shard.ShardId => org.opensearch.core.index.shard.ShardId* org.opensearch.index.Index => org.opensearch.core.index.Index
* org.opensearch.core.index.IndexNotFoundException => org.opensearch.index.IndexNotFoundException

Validation steps were executed to ensure these changes did not break functionality:
* gradle build was successful. A local build was required due to outdated OpenSearch and job scheduler nightly builds.
* Backward compatibility tests were performed on a two-node 2.9 cluster running some detectors. These detectors continued to produce results on a 3.0 cluster with these updates.
* I can start new detectors on the 3.0 node.
* After shutting down a 2.9 node, the job transfer to the 3.0 node was successful and the job continued to perform as expected.

Signed-off-by: Kaituo Li <[email protected]>
    @kaituo
    kaituo committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    da8e4b5 View commit details
    Browse the repository at this point in the history