Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Rcf bump to 2.x #983

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Backport Rcf bump to 2.x #983

merged 2 commits into from
Aug 16, 2023

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Aug 16, 2023

Description

backport #979 and #976 to 2.x branch.

Issues Resolved

#978

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…earch-project#979)

* Update RCF to v3.8 and Enable Auto AD with 'Alert Once' Option

This PR added support for automatic Anomaly Detection (AD) and the 'Alert Once' option introduced in RCF 3.8.

Testing done:

1. Deserialization Test:
* Verified model deserialization from 3.0-rc3.
* Ensured consistent scoring using the rc3 checkpoint and rc3 dependency on identical data.

2. Backward Compatibility Test:
* Executed a mixed cluster with versions 2.10 and 3.0.
* Validated that older detectors still produce results without throwing any exceptions in a blue-green simulation scenario.

Signed-off-by: Kaituo Li <[email protected]>

* reduce recall since alertOnce reduced recall

Signed-off-by: Kaituo Li <[email protected]>

* remove commented out code

Signed-off-by: Kaituo Li <[email protected]>

---------

Signed-off-by: Kaituo Li <[email protected]>
@kaituo
Copy link
Collaborator Author

kaituo commented Aug 16, 2023

Local build passed. CI failed due to failing to find job scheduler:

  • What went wrong:
    Could not determine the dependencies of task ':integTest'.

Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.10.0/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-job-scheduler-2.10.0.0.zip to /home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/job-scheduler/opensearch-job-scheduler-2.10.0.0.zip

@kaituo kaituo merged commit c134346 into opensearch-project:2.x Aug 16, 2023
2 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants