Update to Gradle 8.5 #519
Update to Gradle 8.5 #519
Conversation
Signed-off-by: RS146BIJAY <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage ? 84.16%
Complexity ? 558
=======================================
Files ? 61
Lines ? 2046
Branches ? 146
=======================================
Hits ? 1722
Misses ? 227
Partials ? 97 ☔ View full report in Codecov by Sentry. |
RS146BIJAY
force-pushed
the
main_gradle
branch
3 times, most recently
from
d61d2c6
to
7ec9c00
Compare
RS146BIJAY
requested review from
Bukhtawar,
bharath-techie,
Arpit-Bandejiya and
pranikum
as code owners
Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: RS146BIJAY <[email protected]>
RS146BIJAY
force-pushed
the
main_gradle
branch
from
7ec9c00
to
1834909
Compare
| String bwcVersion = bwcVersionShort + ".0" | ||
| String bwcFilePath = "src/test/resources/org/opensearch/search/asynchronous/bwc/" | ||
| String bwcRemoteFile = "https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/"+ bwcVersionShort + "/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-asynchronous-search-"+ bwcVersion +".zip" | ||
| getPluginResource(bwcFilePath + bwcVersion, bwcRemoteFile) | ||
| //getPluginResource(bwcFilePath + bwcVersion, bwcRemoteFile) |
There was a problem hiding this comment.
why are we commenting this
There was a problem hiding this comment.
Because we are providing it offline. It was unable to download the zip from remote. So inorder to fix build we downloaded it from repository and put in test/resource folder.
|
@RS146BIJAY @bharath-techie I am curious why the original pull request (#516) was not merged? |
|
@RS146BIJAY Please backport to |
* Updating maintainers file Signed-off-by: RS146BIJAY <[email protected]> * Update to Gradle 8.5 Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> --------- Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit bc2b501)
…Update to Gradle 8.5 (#522) * Update to Gradle 8.5 (#519) * Updating maintainers file Signed-off-by: RS146BIJAY <[email protected]> * Update to Gradle 8.5 Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: RS146BIJAY <[email protected]> --------- Signed-off-by: RS146BIJAY <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit bc2b501) * Updates admin credentials used in github workflow (#521) Signed-off-by: RS146BIJAY <[email protected]> (cherry picked from commit a0e9476)
@reta Actually I was not sure why bwc tests were failing for previous PR and we urgently needed to send another change fixing admin credentials. So we took your changes along and tried multiple hit and trails to fix failing bwc and once build passed we pushed this change. Agreed this PR was redundant and could have send previous PR itself with bwc fix. |
Done |
Description
Update to Gradle 8.5
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.