Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to core.common.Strings #1098

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Aug 8, 2023

Description

Refactor for opensearch-project/OpenSearch#9103

From
import org.opensearch.common.Strings
to
import org.opensearch.core.common.Strings

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1098 (0b0f9f9) into main (0e6ad7a) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

❗ Current head 0b0f9f9 differs from pull request most recent head 347d936. Consider uploading reports for the commit 347d936 to get more accurate results

@@             Coverage Diff              @@
##               main    #1098      +/-   ##
============================================
- Coverage     74.58%   74.08%   -0.51%     
+ Complexity     1017     1014       -3     
============================================
  Files           141      141              
  Lines          4761     4761              
  Branches        521      521              
============================================
- Hits           3551     3527      -24     
- Misses          871      895      +24     
  Partials        339      339              
Files Changed Coverage Δ
.../replication/action/stats/FollowerStatsResponse.kt 65.30% <0.00%> (ø)
...ch/replication/action/stats/LeaderStatsResponse.kt 65.21% <0.00%> (ø)
...h/replication/task/index/IndexReplicationParams.kt 77.77% <ø> (ø)
...h/replication/task/shard/ShardReplicationParams.kt 62.22% <ø> (ø)
.../org/opensearch/replication/util/ValidationUtil.kt 59.25% <ø> (ø)

... and 4 files with indirect coverage changes

@monusingh-1 monusingh-1 merged commit 7385ade into opensearch-project:main Aug 8, 2023
10 of 11 checks passed
@monusingh-1 monusingh-1 deleted the fix_strings branch November 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants