[Backport 2.12] Updates integTest behavior to accept the version and set the password accordingly and removes admin:admin reference from the Handbook #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove references to admin:admin Signed-off-by: Derek Ho <[email protected]> * Try to pass in initial admin password via env variable Signed-off-by: Derek Ho <[email protected]> * Try using the env variable Signed-off-by: Derek Ho <[email protected]> * Revert file deletion and add logic for integration tests Signed-off-by: Derek Ho <[email protected]> * fix env variable Signed-off-by: Derek Ho <[email protected]> * Update logic to be the same across all repos Signed-off-by: Derek Ho <[email protected]> * Keep old logic Signed-off-by: Derek Ho <[email protected]> * Change variable name Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 3ea239b)
… accordingly Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit d703887)
DarshitChanpura
requested review from
ankitkala,
monusingh-1 and
saikaranam-amazon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.12 #1328 +/- ##
============================================
+ Coverage 74.66% 76.19% +1.52%
- Complexity 1026 1046 +20
============================================
Files 141 141
Lines 4784 4784
Branches 526 526
============================================
+ Hits 3572 3645 +73
+ Misses 865 787 -78
- Partials 347 352 +5 ☔ View full report in Codecov by Sentry. |
monusingh-1
approved these changes
Feb 9, 2024
ankitkala
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports 3ea239b from #1298
Backports d703887 from #1318
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.