-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exception for the updation of a replication rule #1405
Handle exception for the updation of a replication rule #1405
Conversation
Signed-off-by: Sanjay Kumar <[email protected]>
Hi @ankitkala & @monusingh-1 , Please provide feedback :) |
Signed-off-by: Sanjay Kumar <[email protected]>
Hi @ankitkala @monusingh-1 and other maintainers, I could see the integTest is failing for the below test case -
I was able to find a PR which involves the exclusion of this test case in integTestRemote Task but not in integTest. I have for now excluded this particular test case from the integTest. Let me know if any other plan to fix this test case? |
…in mixed mode' in integTest Signed-off-by: Sanjay Kumar <[email protected]>
Signed-off-by: Sanjay Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
Signed-off-by: Sanjay Kumar <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1405-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2da20341107bfe707487d93d271df70aed31356d
# Push it to GitHub
git push --set-upstream origin backport/backport-1405-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
This PR handles the exception handling for updation of a replication rule.
Earlier behavior:
First hit of the replication rule:
Second hit of the same Replication rule:
New behavior:
First hit of the replication rule:
Second hit of the Replication rule:
Issues Resolved
#1394
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.