Misc bug fixes and minor UX improvements II #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
added
bug
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
saimedhi
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
- Looks good to me.
- Could you please merge integration test workflow. So, that integration tests start running on PRs.Added Integration Tests Workflow #426
- With the changes in this PR, I'll make the necessary updates to the integration test specs in the Functional Test repo. Thank you!
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
|
@ohltyler Thanks for your updates! |
Signed-off-by: Tyler Ohlsen <[email protected]>
|
@kamingleung I've remove spacing entirely and kept it aligned to the right. The little bit of remaining visible "spacing" is due to the empty button itself. Lmk if concerns or if I should override the button widths to get them even closer. 
|
|
@ohltyler , I am okay merging this PR. I am fixing integ tests. |
|
Integ tests passing. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Change readonly fields into codeblock Signed-off-by: Tyler Ohlsen <[email protected]> * Change which panel is collapsible; various wording changes Signed-off-by: Tyler Ohlsen <[email protected]> * Move edit buttons of ingest/search in header; spacing cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * Update wording and layout of input/output transform form components Signed-off-by: Tyler Ohlsen <[email protected]> * update tests Signed-off-by: Tyler Ohlsen <[email protected]> * remove gutter entirely on query buttons Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f3d665c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #427 . Changes:
EuiCodeBlockDemo video highlighting changes:
screen-capture.11.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.