bug fix to switch to default datasource instead of local cluster when initial loading #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initial loading Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
force-pushed
the
neo-fixes
branch
from
10c486b to
46020cc
Compare
SuZhou-Joe
reviewed
Oct 28, 2024
| validate: false, | ||
| validate: dataSourceEnabled ? { | ||
| query: schema.object({ | ||
| dataSourceId: schema.string(), |
There was a problem hiding this comment.
Should this be schema.maybe(schema.string())? If MDS enabled, will we always have dataSourceId in the query?
SuZhou-Joe
approved these changes
Oct 28, 2024
sbcd90
approved these changes
Oct 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
… initial loading (#290) * bug fix to switch to default datasource instead of local cluster when initial loading Signed-off-by: Riya Saxena <[email protected]> * notifications bug fix Signed-off-by: Riya Saxena <[email protected]> * notif fixes Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 2315c54) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
… initial loading (#290) * bug fix to switch to default datasource instead of local cluster when initial loading Signed-off-by: Riya Saxena <[email protected]> * notifications bug fix Signed-off-by: Riya Saxena <[email protected]> * notif fixes Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 2315c54) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 28, 2024
… initial loading (#290) (#291) * bug fix to switch to default datasource instead of local cluster when initial loading * notifications bug fix * notif fixes --------- (cherry picked from commit 2315c54) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 28, 2024
… initial loading (#290) (#292) * bug fix to switch to default datasource instead of local cluster when initial loading * notifications bug fix * notif fixes --------- (cherry picked from commit 2315c54) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dashboards-notifs.mov
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.