[Backport 2.x] [Multi datasource] Update order of validation; catch exceptions in semver check #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 71411b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan,
AWSHurneyt and
riysaxen-amzn
as code owners
amsiglan
approved these changes
Oct 30, 2024
Hailong-am
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #298 +/- ##
==========================================
- Coverage 82.63% 82.21% -0.42%
==========================================
Files 55 55
Lines 1687 1726 +39
Branches 456 450 -6
==========================================
+ Hits 1394 1419 +25
- Misses 286 300 +14
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 71411b4 from #297.